Re: [PATCH 0/4] clk: qcom: dispcc: fix DisplayPort link clocks

From: Bjorn Andersson
Date: Sat Apr 20 2024 - 14:05:21 EST


On Mon, Apr 08, 2024 at 02:47:03PM +0300, Dmitry Baryshkov wrote:
> On several Qualcomm platforms DisplayPort link clocks used incorrect
> frequency tables. Drop frequency tables and use clk_byte2_ops instead of
> clk_rcg2_ops.
>
> Note, this was tested on SM8450 only and then extended to other
> platforms.
>

As Stephen points out, it seems from the commit messages that this just
cleans up the code because it's wrong. But both Luca and Neil points out
that it resolves a visible issue/error.

Can we please have this (the actual problem being resolved) captured in
the commit messages?

Regards,
Bjorn

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> Dmitry Baryshkov (4):
> clk: qcom: dispcc-sm8450: fix DisplayPort clocks
> clk: qcom: dispcc-sm6350: fix DisplayPort clocks
> clk: qcom: dispcc-sm8550: fix DisplayPort clocks
> clk: qcom: dispcc-sm8650: fix DisplayPort clocks
>
> drivers/clk/qcom/dispcc-sm6350.c | 11 +----------
> drivers/clk/qcom/dispcc-sm8450.c | 20 ++++----------------
> drivers/clk/qcom/dispcc-sm8550.c | 20 ++++----------------
> drivers/clk/qcom/dispcc-sm8650.c | 20 ++++----------------
> 4 files changed, 13 insertions(+), 58 deletions(-)
> ---
> base-commit: 8568bb2ccc278f344e6ac44af6ed010a90aa88dc
> change-id: 20240408-dispcc-dp-clocks-5ee5d5926346
>
> Best regards,
> --
> Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>