Re: [PATCH v3 2/2] of: dynamic: Fix overlayed devices not probing because of fw_devlink

From: Saravana Kannan
Date: Wed Apr 17 2024 - 02:29:36 EST


On Sun, Apr 14, 2024 at 6:06 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Apr 12, 2024 at 07:54:32AM -0500, Rob Herring wrote:
> > On Thu, Apr 11, 2024 at 6:56 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
>
> > > +#define get_dev_from_fwnode(fwnode) get_device((fwnode)->dev)
>
> > I think it is better to not have this wrapper. We want it to be clear
> > when we're acquiring a ref. I know get_device() does that, but I have
> > to look up what get_dev_from_fwnode() does exactly.
>
> Or perhaps calling it get_device_from_fwnode() would make it more
> obvious that it is a get_device() variant?

Ack, I'll do this in my next version. Right now I'm waiting for Herve
and Geert to confirm this series fixes their issues.

-Saravana