Re: [PATCH v4 4/6] cgroup/pids: Add pids.events.local

From: Tejun Heo
Date: Tue Apr 16 2024 - 15:32:24 EST


On Tue, Apr 16, 2024 at 04:20:12PM +0200, Michal Koutný wrote:
> struct cgroup_subsys pids_cgrp_subsys = {
> .css_alloc = pids_css_alloc,
> .css_free = pids_css_free,
> @@ -416,5 +469,6 @@ struct cgroup_subsys pids_cgrp_subsys = {
> .cancel_fork = pids_cancel_fork,
> .release = pids_release,
> .dfl_cftypes = pids_files,
> + .legacy_cftypes = pids_files_legacy,

Ah, you restore it here. I see what you're doing now. It may be better to
reorder patches so that .local is added first or just keep the legacy file
behavior temporarily altered than removing them altogether, but this isn't
the end of the world either. Can you please explicitly note what you're
doing in the commit message?

Thanks.

--
tejun