Re: [PATCH 2/3] media: tuners: xc5000: fix error code handling in xc5000_attach()

From: Sergey Shtylyov
Date: Tue Apr 16 2024 - 14:59:12 EST


On 4/16/24 2:45 PM, Roman Smirnov wrote:

> xc5000_attach() uses the hybrid_tuner_request_state() macro.
> It may return the error code -ENOMEM, but the function handle

Handles (just noticed that grammar issue in all 3 patches).

> the value 0 instead.
>
> Found by Linux Verification Center (linuxtesting.org) with Svace.
>
> Fixes: b9302fa7ed97 ("media: tuners: fix error return code of hybrid_tuner_request_state()")
> Signed-off-by: Roman Smirnov <r.smirnov@xxxxxx>

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

[...]

MBR, Sergey