Re: [PATCH] coccinelle: misc: minmax: Suppress reports for err returns

From: Ricardo Ribalda
Date: Tue Apr 16 2024 - 07:33:16 EST


Hi Markus

On Tue, 16 Apr 2024 at 13:30, Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
>
> > +++ b/scripts/coccinelle/misc/minmax.cocci
> > @@ -50,11 +50,26 @@ func(...)
> > ...>
> > }
> >
> > +// Ignore errcode returns.
> > +@errcode@
>
>
> I see that you would like to omit the specification “depends on patch”
> from the previous SmPL rule location.
>
> Would you really like to influence and adjust SmPL code any more
> according to affected coccicheck operation modes?

I probably do not know what I am doing :), it is my first .cocci patch.

If I leave the "depends on patch", then the change is ignored in report mode.

I think errcode needs to be executed in report and in patch mode, but
there might be a better way to do it.

>
> Regards,
> Markus



--
Ricardo Ribalda