Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

From: Greg KH
Date: Tue Apr 16 2024 - 00:54:34 EST


On Tue, Apr 16, 2024 at 03:52:40AM +0000, Zhu Wang wrote:
> From: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
>
> stable inclusion
> from stable-v6.7.3
> commit 2ef98c6d753a744e333b7e34b9cf687040fba57d
> category: bugfix
> bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BV4C
> CVE: CVE-2023-52624
>
> Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2ef98c6d753a744e333b7e34b9cf687040fba57d
>
> --------------------------------
>
> [ Upstream commit e5ffd1263dd5b44929c676171802e7b6af483f21 ]
>
> [Why]
> DMCUB can be in idle when we attempt to interface with the HW through
> the GPINT mailbox resulting in a system hang.
>
> [How]
> Add dc_wake_and_execute_gpint() to wrap the wake, execute, sleep
> sequence.
>
> If the GPINT executes successfully then DMCUB will be put back into
> sleep after the optional response is returned.
>
> It functions similar to the inbox command interface.
>
> Cc: Mario Limonciello <mario.limonciello@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Hansen Dsouza <hansen.dsouza@xxxxxxx>
> Acked-by: Wayne Lin <wayne.lin@xxxxxxx>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx>
> Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
>
> This commit comes from following commits:
>
> 8774029f76b9 ("drm/amd/display: Add DCN35 CLK_MGR")
> 65138eb72e1f ("drm/amd/display: Add DCN35 DMUB")
> dc01c4b79bfe ("drm/amd/display: Update driver and IPS interop")
> 820c3870c491 ("drm/amd/display: Refactor DMCUB enter/exit idle interface")
> 2ef98c6d753a ("drm/amd/display: Wake DMCUB before executing GPINT commands")

Why are you putting multiple commits together and not just submitting
the individual ones? And what is this for?

confused,

greg k-h