Re: [PATCH 0/4] regulator: Fix AXP717 PMIC support

From: Lee Jones
Date: Thu Apr 11 2024 - 07:22:48 EST


On Fri, 29 Mar 2024, Andre Przywara wrote:

> Here are some fixes to the AXP717 PMIC support series. Lee put that in
> an immutable branch already, so these here go on top.
> Patch 1 contains fixes to the regulator descriptions: the LDOs had the
> wrong supply source, and two numbers were wrong. The datasheet describes
> the voltage ranges and register values differently from what our macros
> expect, in a way that literally begs for off-by-ones, so here you go.
> I don't know if that's still feasible, but it would be a good candidate
> to squash into the patch that it fixes.
>
> The other three patches add the "boost" regulator, which is meant to
> provide the 5V USB VBUS power when operating from the battery. It's the
> usual trinity of binding/mfd/regulator patches.
> Again this could be squashed into the respective patches from the
> original series, if people agree.
>
> Please have a look and test on a device, since I could not do this.
>
> Based on mfd/ib-mfd-regulator-6.10, as detailed below.
>
> Cheers,
> Andre
>
> Andre Przywara (4):
> regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones
> dt-bindings: mfd: x-powers,axp152: add boost regulator
> mfd: axp20x: AXP717: Add support for boost regulator
> regulator: axp20x: AXP717: Add boost regulator
>
> .../bindings/mfd/x-powers,axp152.yaml | 2 +-
> drivers/mfd/axp20x.c | 2 ++
> drivers/regulator/axp20x-regulator.c | 32 +++++++++++--------
> include/linux/mfd/axp20x.h | 3 ++
> 4 files changed, 24 insertions(+), 15 deletions(-)

I need an Ack from Mark before I can process these.

--
Lee Jones [李琼斯]