Re: [patch 3/4] x86/topology: Handle the !APIC case gracefully

From: Guenter Roeck
Date: Fri Mar 22 2024 - 17:41:49 EST


On Fri, Mar 22, 2024 at 07:56:38PM +0100, Thomas Gleixner wrote:
> If there is no local APIC enumerated and registered then the topology
> bitmaps are empty. Therefore topology_init_possible_cpus() will die with a
> division by zero exception.
>
> Prevent this by registering a fake APIC id to populate the topology
> bitmap. This also allows to use all topology query interfaces
> unconditionally. It does not affect the actual APIC code because either the
> local APIC address was not registered or no local APIC could be detected.
>
> Fixes: f1f758a80516 ("x86/topology: Add a mechanism to track topology via APIC IDs")
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Reported-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter