Re: [PATCH 0/2] Fixes for recent x86/boot rip-relative addressing changes

From: Tom Lendacky
Date: Fri Mar 22 2024 - 14:06:04 EST


On 3/22/24 11:10, Ard Biesheuvel wrote:
On Fri, 22 Mar 2024 at 17:41, Tom Lendacky <thomas.lendacky@xxxxxxx> wrote:

This patch series provides fixes for the recent x86/boot rip-relative
addressing changes that causes system crashes when booting with 5-level
pagetables and SME active.

I thought I had tested 5-level paging with SME, but must have missed
it. There are two patches to fix the issues that can be squashed into
a single patch with multiple Fixes: tags if desired.


Perhaps you tested the entire series, where the final patch removed
those variables altogether?

Maybe, but that wouldn't explain the first fix in the series. I should've encountered an issue no matter what. I probably used the wrong config file or ... who knows at this point.

Thanks,
Tom


The second patch is sort of a revert, but instead uses the newer
RIP_REL_REF() macro instead of reverting the fix and continuing to use
the fixup_pointer() support.


Thanks for fixing this.

Series

Reviewed-by: Ard Biesheuvel <ardb@xxxxxxxxxx>