Re: [PATCH v3] net: hsr: Provide RedBox support

From: Simon Horman
Date: Fri Mar 22 2024 - 08:48:26 EST


On Fri, Mar 22, 2024 at 08:42:44AM +0100, Lukasz Majewski wrote:
> Dear Community,
>
> > Introduce RedBox support (HSR-SAN to be more precise) for HSR
> > networks. Following traffic reduction optimizations have been
> > implemented:
> > - Do not send HSR supervisory frames to Port C (interlink)
> > - Do not forward to HSR ring frames addressed to Port C
> > - Do not forward to Port C frames from HSR ring
> > - Do not send duplicate HSR frame to HSR ring when destination is
> > Port C
> >
> > The corresponding patch to modify iptable2 sources has already been
> > sent:
> > https://lore.kernel.org/netdev/20240308145729.490863-1-lukma@xxxxxxx/T/
> >
> > Testing procedure:
> > ------------------
> > The EVB-KSZ9477 has been used for testing on net-next branch
> > (SHA1: 709776ea8562).
> >
> > Ports 4/5 were used for SW managed HSR (hsr1) as first hsr0 for ports
> > 1/2 (with HW offloading for ksz9477) was created. Port 3 has been
> > used as interlink port (single USB-ETH dongle).
> >
> > Configuration - RedBox (EVB-KSZ9477):
> > ifconfig lan1 down;ifconfig lan2 down
> > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45
> > version 1 ip link add name hsr1 type hsr slave1 lan4 slave2 lan5
> > interlink lan3 supervision 45 version 1 ifconfig lan4 up;ifconfig
> > lan5 up ifconfig lan3 up
> > ifconfig hsr1 192.168.0.11 up
> >
> > Configuration - DAN-H (EVB-KSZ9477):
> >
> > ifconfig lan1 down;ifconfig lan2 down
> > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45
> > version 1 ip link add name hsr1 type hsr slave1 lan4 slave2 lan5
> > supervision 45 version 1 ifconfig lan4 up;ifconfig lan5 up
> > ifconfig hsr1 192.168.0.12 up
> >
> > This approach uses only SW based HSR devices (hsr1).
> >
> > -------------- ----------------- ------------
> > DAN-H Port5 | <------> | Port5 | |
> > Port4 | <------> | Port4 Port3 | <---> | PC
> > | | (RedBox) | | (USB-ETH)
> > EVB-KSZ9477 | | EVB-KSZ9477 | |
> > -------------- ----------------- ------------
> >
>
> Gentle ping for this patch...

Hi Lukasz,

Unfortunately the timing of this patch submission didn't work out:
it was submitted after or otherwise still under review
when Linus tagged v6.8 and the merge window for v6.9 started.

net-next is closed during the merge window and the usual
next step in cases such as this is to rebase and repost
once the merge window closes and net-next reopens.
That should occur next week.

See: https://docs.kernel.org/process/maintainer-netdev.html#git-trees-and-patch-flow