Re: [PATCH v2 4/4] virt: vmgenid: add support for devicetree bindings

From: kernel test robot
Date: Thu Mar 21 2024 - 15:53:33 EST


Hi Sudan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on a4145ce1e7bc247fd6f2846e8699473448717b37]

url: https://github.com/intel-lab-lkp/linux/commits/Sudan-Landge/virt-vmgenid-rearrange-code-to-make-review-easier/20240321-105317
base: a4145ce1e7bc247fd6f2846e8699473448717b37
patch link: https://lore.kernel.org/r/20240321025105.53210-5-sudanl%40amazon.com
patch subject: [PATCH v2 4/4] virt: vmgenid: add support for devicetree bindings
config: x86_64-randconfig-123-20240321 (https://download.01.org/0day-ci/archive/20240322/202403220322.EGtpD4Jw-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240322/202403220322.EGtpD4Jw-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403220322.EGtpD4Jw-lkp@xxxxxxxxx/

sparse warnings: (new ones prefixed by >>)
>> drivers/virt/vmgenid.c:153:43: sparse: sparse: cast removes address space '__iomem' of expression

vim +/__iomem +153 drivers/virt/vmgenid.c

133
134 static int vmgenid_add_of(struct device *dev, struct vmgenid_state *state)
135 {
136 #ifdef CONFIG_OF
137 struct resource res;
138 int ret = 0;
139
140 if (of_address_to_resource(dev->of_node, 0, &res)) {
141 dev_err(dev, "Failed to get resources from device tree");
142 ret = -EINVAL;
143 goto out;
144 }
145
146 if (!__request_mem_region(res.start, resource_size(&res),
147 "vmgenid", IORESOURCE_EXCLUSIVE)) {
148 dev_err(dev, "Failed to request mem region");
149 ret = -EINVAL;
150 goto out;
151 }
152
> 153 ret = setup_vmgenid_state(state, (u8 *)of_iomap(dev->of_node, 0));
154 if (ret)
155 goto out;
156
157 state->irq = irq_of_parse_and_map(dev->of_node, 0);
158 dev->driver_data = state;
159
160 if (request_irq(state->irq, vmgenid_of_irq_handler,
161 IRQF_SHARED, "vmgenid", dev) < 0) {
162 dev_err(dev, "request_irq failed");
163 dev->driver_data = NULL;
164 ret = -EINVAL;
165 goto out;
166 }
167
168 out:
169 return ret;
170 #else
171 (void)dev;
172 (void)state;
173 return -EINVAL;
174 #endif
175 }
176

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki