Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for Vivobook GPU MUX

From: Luke Jones
Date: Wed Mar 20 2024 - 16:08:26 EST


On Thu, 21 Mar 2024, at 1:02 AM, Ilpo Järvinen wrote:
> On Wed, 20 Mar 2024, Luke Jones wrote:
>
> > On Wed, 20 Mar 2024, at 1:26 AM, Ilpo Järvinen wrote:
> > > On Sun, 10 Mar 2024, Luke D. Jones wrote:
> > >
> > > > Adjust existing MUX support to select whichever MUX support is available
> > > > so that ASUS Vivobook MUX can also be used if detected.
> > >
> > > This description is a bit on the short side. It wouldn't have hurt to
> > > first state that Vivobooks come with a GPU MUX WMI that has a different
> > > WMI device ID. I can infer that after reading the diff but the description
> > > should not require reading the patch.
> >
> > Would you prefer I changed the commit message?
>
> I kind of tried to give some leeway for you and not sound like I'm
> enforcing you to do it but yes,

Hey it's not a problem at all. Part of the review and all feedback is valuable :)