Re: [PATCH 2/2] KVM: s390: vsie: Use virt_to_phys for facility control block

From: David Hildenbrand
Date: Wed Mar 20 2024 - 07:35:50 EST


On 19.03.24 17:44, Nina Schoetterl-Glausch wrote:
In order for SIE to interpretively execute STFLE, it requires the real
or absolute address of a facility-list control block.
Before writing the location into the shadow SIE control block, convert
it from a virtual address.
We currently do not run into this bug because the lower 31 bits are the
same for virtual and physical addresses.

So it's not a bug (yet) :)

But certainly the right thing to do and more future-proof.

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb