Re: [PATCH v6 04/13] crypto: ecdsa - Extend res.x mod n calculation for NIST P521

From: Jarkko Sakkinen
Date: Mon Mar 18 2024 - 18:19:13 EST


On Mon Mar 18, 2024 at 10:39 PM EET, Lukas Wunner wrote:
> On Mon, Mar 18, 2024 at 10:33:47PM +0200, Jarkko Sakkinen wrote:
> > On Tue Mar 12, 2024 at 8:36 PM EET, Stefan Berger wrote:
> > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > > Tested-by: Lukas Wunner <lukas@xxxxxxxxx>
> >
> > What was there to test in this anyway? I see only comment change below.
>
> The full series was tested, irrespective of the content of the individual
> patches.

Tested-by's should be per patch, and in this patch tested-by has no
meaning at all.

In order to determine which patches tested-by is applicable it can
be derived on what was actually tested.

This looks as tested-by was used in place of acked/reviewed-by, which
is not how it should be used.

BR, Jarkko