Re: [PATCH v3] keys: update key quotas in key_put()

From: Luis Henriques
Date: Mon Mar 18 2024 - 17:38:35 EST


"Jarkko Sakkinen" <jarkko@xxxxxxxxxx> writes:

> On Wed Mar 13, 2024 at 2:37 PM EET, Luis Henriques wrote:
>> Luis Henriques <lhenriques@xxxxxxx> writes:
>>
>> > David Howells <dhowells@xxxxxxxxxx> writes:
>> >
>> >> Luis Henriques <lhenriques@xxxxxxx> wrote:
>> >>
>> >>> Delaying key quotas update when key's refcount reaches 0 in key_put() has
>> >>> been causing some issues in fscrypt testing, specifically in fstest
>> >>> generic/581. This commit fixes this test flakiness by dealing with the
>> >>> quotas immediately, and leaving all the other clean-ups to the key garbage
>> >>> collector.
>> >>
>> >> Okay, I'll accept this.
>> >>
>> >
>> > That's awesome, thanks a lot David. And, as Eric requested, I'll send out
>> > shortly a follow-up fscrypt-specific patch, which will make generic/581
>> > fstest finally pass.
>>
>> Ping. Looks like this fell through the cracks...?
>>
>> I took a quick look at some git trees ('jarkko' and 'dhowells') but
>> couldn't see this patch anywhere.
>>
>> Cheers,
>
> My bad! I'll pick this up now.

Awesome, thanks a lot Jarkko.

Cheers,
--
Luis