Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver

From: Markus Elfring
Date: Mon Mar 18 2024 - 14:12:56 EST



> +++ b/drivers/misc/mikrobus/mikrobus_core.h

> +#ifndef __MIKROBUS_H
> +#define __MIKROBUS_H


I suggest to avoid the specification of leading underscores for include guards.

See also:
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29


Regards,
Markus