Re: [PATCH] init: open /initrd.image with O_LARGEFILE

[Randy Dunlap]

Hi,

On 3/17/24 15:15, John Sperbeck wrote:
> If initrd data is larger than 2Gb, we'll eventually fail to write to
> the /initrd.image file when we hit that limit, unless O_LARGEFILE is set.
> 

Could this be related to
https://lore.kernel.org/lkml/CAHY78BqCpMQptPN0SMaXuRqHOhYi+wnMEUSTYt7OHDZih4e7yQ@xxxxxxxxxxxxxx/
?

Thanks.

> Signed-off-by: John Sperbeck <jsperbeck@xxxxxxxxxx>
> ---
>  init/initramfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/initramfs.c b/init/initramfs.c
> index 76deb48c38cb..b607d3463b47 100644
> --- a/init/initramfs.c
> +++ b/init/initramfs.c
> @@ -683,7 +683,7 @@ static void __init populate_initrd_image(char *err)
>  
>  	printk(KERN_INFO "rootfs image is not initramfs (%s); looks like an initrd\n",
>  			err);
> -	file = filp_open("/initrd.image", O_WRONLY | O_CREAT, 0700);
> +	file = filp_open("/initrd.image", O_WRONLY|O_CREAT|O_LARGEFILE, 0700);
>  	if (IS_ERR(file))
>  		return;
>  

-- 
#Randy