Re: [PATCH v2 3/3] arm64: dts: allwinner: h616: add support for T95 tv boxes

[Kamil Kasperski]

W dniu 17.03.2024 o 15:57, Krzysztof Kozlowski pisze:
> On 17/03/2024 02:34, Kamil Kasperski wrote:
>> Add dtsi file for T95 tv boxes and add initial
>> support for T95 5G AXP313A variant with a board name
>> H616-T95MAX-AXP313A-v3.0
>>
>> internal NAND chip is connected to NAND controller
>> I can't see any nand in sun50i-h616.dtsi, so access to
>> internal memory is not implemented.
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
>> Signed-off-by: Kamil Kasperski <ressetkk@xxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/allwinner/Makefile             |   1 +
>>  arch/arm64/boot/dts/allwinner/sun50i-h616-t95.dtsi | 109 +++++++++++++++++++++
>>  .../dts/allwinner/sun50i-h616-t95max-axp313.dts    |  85 ++++++++++++++++
>>  3 files changed, 195 insertions(+)
>>
>> +
>> +	reg_vcc3v3: vcc3v3 {
>> +		/* discrete 3.3V regulator */
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vcc-3v3";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-always-on;
>> +	};
>> +
>> +	wifi_pwrseq: wifi_pwrseq {
> No underscores in node names. From where did you copy this code?

arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts#L44
Seems this one needs a fixup.

>> +		compatible = "mmc-pwrseq-simple";
>> +		clocks = <&rtc CLK_OSC32K_FANOUT>;
>> +		clock-names = "ext_clock";
>> +		pinctrl-0 = <&x32clk_fanout_pin>;
>> +		pinctrl-names = "default";
>> +		reset-gpios = <&pio 6 18 GPIO_ACTIVE_LOW>; /* PG18 */
>> +	};
>> +};
>> +
>
> Best regards,
> Krzysztof
>