Re: [PATCH] mm/zsmalloc: move get_zspage_lockless into #ifdef

[Chengming Zhou]

On 2024/2/28 17:40, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> It's only used from inside of an #ifdef section, causing a warning otherwise:
> 
> mm/zsmalloc.c:735:23: error: unused function 'get_zspage_lockless' [-Werror,-Wunused-function]
>   735 | static struct zspage *get_zspage_lockless(struct page *page)
>       |                       ^~~~~~~~~~~~~~~~~~~
> 
> Move it down into that block to avoid adding another #ifdef.
> 
> Fixes: 2258bdebb55e ("mm/zsmalloc: don't hold locks of all pages when free_zspage()")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Hello Arnd,

Thanks for your fix! But this series has problem and should be removed by Andrew later[1][2].

[1] https://lore.kernel.org/all/20240228043534.GG11972@xxxxxxxxxx/
[2] https://lore.kernel.org/all/20240228035403.GE11972@xxxxxxxxxx/

Thanks!