Re: [PATCH net-next v5 3/3] net: dsa: realtek: support reset controller

From: Alvin Šipraga
Date: Mon Feb 26 2024 - 08:59:29 EST


On Sun, Feb 25, 2024 at 01:29:55PM -0300, Luiz Angelo Daros de Luca wrote:
> Add support for resetting the device using a reset controller,
> complementing the existing GPIO reset functionality (reset-gpios).
>
> Although the reset is optional and the driver performs a soft reset
> during setup, if the initial reset pin state was asserted, the driver
> will not detect the device until the reset is deasserted.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---

Reviewed-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>

> drivers/net/dsa/realtek/realtek.h | 2 ++
> drivers/net/dsa/realtek/rtl83xx.c | 42 ++++++++++++++++++++++++++++++++++-----
> drivers/net/dsa/realtek/rtl83xx.h | 2 ++
> 3 files changed, 41 insertions(+), 5 deletions(-)