Re: [PATCH 1/2] mm/zswap: global lru and shrinker shared by all zswap_pools

From: Chengming Zhou
Date: Mon Feb 12 2024 - 08:32:06 EST


On 2024/2/12 03:01, kernel test robot wrote:
> Hi Chengming,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on 191d97734e41a5c9f90a2f6636fdd335ae1d435d]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Chengming-Zhou/mm-zswap-global-lru-and-shrinker-shared-by-all-zswap_pools/20240211-220028
> base: 191d97734e41a5c9f90a2f6636fdd335ae1d435d
> patch link: https://lore.kernel.org/r/20240210-zswap-global-lru-v1-1-853473d7b0da%40bytedance.com
> patch subject: [PATCH 1/2] mm/zswap: global lru and shrinker shared by all zswap_pools
> config: x86_64-randconfig-013-20240211 (https://download.01.org/0day-ci/archive/20240212/202402120226.TK7G37U9-lkp@xxxxxxxxx/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240212/202402120226.TK7G37U9-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202402120226.TK7G37U9-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
> mm/zswap.c: In function 'zswap_shrinker_count':
>>> mm/zswap.c:1300:42: error: 'pool' undeclared (first use in this function); did you mean 'zpool'?
> 1300 | nr_backing = get_zswap_pool_size(pool) >> PAGE_SHIFT;

Forgot to test with !CONFIG_MEMCG_KMEM, need to change to zswap_pool_total_size here.

Thanks.