Re: [PATCH] iommu/amd: Mark interrupt as managed

From: Mario Limonciello
Date: Fri Feb 09 2024 - 10:49:12 EST


On 2/9/2024 02:24, Joerg Roedel wrote:
Hi Mario,

On Mon, Feb 05, 2024 at 10:31:47AM -0600, Mario Limonciello wrote:
Friendly ping on reviewing this patch.

Thanks for the patch. Since this is a fix the patch should contain a
Fixes: tag. Also a review from Suravee and/or Vasant would be great.

Thanks,

Joerg


Thanks! This problem should go all the way to when MSI support was introduced (2.6.28):

a80dc3e0e0dc ("AMD IOMMU: add MSI interrupt support")

But I don't think that's a correct fixes tag because
irq_managed wasn't introduced until 3.19:

cffe0a2b5a34 ("x86, irq: Keep balance of IOAPIC pin reference count")

But then I tried to go off the original introduction of the error message, but that's quite ancient.

1da177e4c3f4 ("Linux-2.6.12-rc2")

So which tag do you think is appropriate to use? I'm tempted to say this should just be without a fixes tag just a:

Cc: stable@xxxxxxxxxxxxxxx # 3.19+