Re: [PATCH 1/3] Input: matrix_keypad - avoid repeatedly converting GPIO to IRQ

From: Dmitry Torokhov
Date: Wed Jan 31 2024 - 13:48:43 EST


On Mon, Jan 22, 2024 at 09:19:56AM +0100, Bartosz Golaszewski wrote:
> On Sun, 21 Jan 2024 at 06:32, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> >
> > gpio_to_irq() is getting more expensive and may require sleeping.
>
> This is no longer true, the relevant commit was reverted and I have
> now a working series where I'm using SRCU for lockless list traversal
> so if anything it will actually become cheaper.
>
> > Convert row GPIOs to interrupt numbers once in probe() and use
> > this information when the driver needs to enable or disable given
> > interrupt line.
>
> That being said, I'm not against this change, though this may not be
> very useful after all.

OK, then I'll tone down the patch description and apply.

Thanks.

--
Dmitry