Re: [drm-drm-misc:drm-misc-next] dt-bindings: nt35510: document 'port' property

From: Rob Herring
Date: Tue Jan 30 2024 - 10:14:41 EST


On Sat, Jan 27, 2024 at 04:28:08PM +0100, Dario Binacchi wrote:
> Allow 'port' property (coming from panel-common.yaml) to be used in DTS:
>
> st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
>
> ---
>
> .../display/panel/novatek,nt35510.yaml | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> index a4afaff483b7..72913719df23 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
> @@ -31,6 +31,22 @@ properties:
> vddi-supply:
> description: regulator that supplies the vddi voltage
> backlight: true
> + port:
> + $ref: /schemas/graph.yaml#/properties/port

Just 'port: true'

> +
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - frida,frd400b25025
> +then:
> + required:
> + - port
> +
> +else:
> + properties:
> + port: false

No need for this. 'port' should be allowed for everyone.

>
> required:
> - compatible
> @@ -54,5 +70,23 @@ examples:
> backlight = <&gpio_bl>;
> };
> };
> + - |
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "frida,frd400b25025", "novatek,nt35510";
> + vddi-supply = <&vcc_3v3>;
> + vdd-supply = <&vcc_3v3>;
> + reg = <0>; /* dsi virtual channel (0..3) */
> + reset-gpios = <&gpioj 15 GPIO_ACTIVE_LOW>;
>
> + port {
> + dsi_panel_in: endpoint {
> + remote-endpoint = <&dsi_out>;
> + };
> + };
> + };
> + };
> ...
> --
> 2.43.0
>