RE: [PATCH] drivers: clk: zynqmp: remove clock name dependency

From: Trivedi Manojbhai, Naman
Date: Mon Jan 29 2024 - 11:50:16 EST


Hi Stephen,

A gentle reminder. Can you please help me to clarify the below query?

Thanks,
Naman

>-----Original Message-----
>From: Trivedi Manojbhai, Naman
>Sent: Tuesday, January 9, 2024 4:55 PM
>To: Stephen Boyd <sboyd@xxxxxxxxxx>; abel.vesa@xxxxxxxxxx;
>angelogioacchino.delregno@xxxxxxxxxxxxx; Simek, Michal
><michal.simek@xxxxxxx>; mturquette@xxxxxxxxxxxx; robh@xxxxxxxxxx
>Cc: linux-clk@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx
>Subject: RE: [PATCH] drivers: clk: zynqmp: remove clock name dependency
>
>Hi Stephen,
>
>Thanks for review. Please find my response inline.
>
>Thanks,
>Naman
>
>>-----Original Message-----
>>From: Stephen Boyd <sboyd@xxxxxxxxxx>
>>Sent: Thursday, January 4, 2024 6:30 AM
>>To: Trivedi Manojbhai, Naman <Naman.TrivediManojbhai@xxxxxxx>;
>>abel.vesa@xxxxxxxxxx; angelogioacchino.delregno@xxxxxxxxxxxxx;
>>krzysztof.kozlowski@xxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>;
>>mturquette@xxxxxxxxxxxx; robh@xxxxxxxxxx
>>Cc: linux-clk@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
>>linux- kernel@xxxxxxxxxxxxxxx; Trivedi Manojbhai, Naman
>><Naman.TrivediManojbhai@xxxxxxx>
>>Subject: Re: [PATCH] drivers: clk: zynqmp: remove clock name dependency
>>
>>Caution: This message originated from an External Source. Use proper
>>caution when opening attachments, clicking links, or responding.
>>
>>
>>Quoting Naman Trivedi Manojbhai (2024-01-02 23:20:17)
>>> Currently, from zynqmp_get_parent_list() function the clock driver
>>> references the clock by name instead of its reference from device tree.
>>> This causes problem when the clock name in the device tree is changed.
>>>
>>> Remove hard dependency of clock name and update the logic to use
>>> clock reference from device tree instead of clock name.
>>
>>Please use struct clk_parent_data instead.
>Can you please clarify how struct clk_parent_data can be used here?
>
>The zynqmp clock driver receives clock parent information from firmware and it
>is stored in struct clock_parent. In this patch, I added logic to get the parent
>clock reference from device tree and get corresponding clock name. Can you
>please explain how the struct clk_parent_data can be used for the same?
>
>Thanks,
>Naman