Re: [PATCH 0/2] min_heap: Min heap optimizations

From: Ian Rogers
Date: Wed Jan 03 2024 - 12:56:57 EST


On Wed, Dec 20, 2023 at 12:32 AM Kuan-Wei Chiu <visitorckw@xxxxxxxxx> wrote:
>
> Hello,
>
> The purpose of this patch series is to enhance the existing min heap
> implementation. The optimization focuses on both the heap construction
> process and the number of comparisons made during the heapify
> operation.
>
> Kuan-Wei Chiu (2):
> min_heap: Optimize number of calls to min_heapify()
> min_heap: Optimize number of comparisons in min_heapify()

Thanks Kuan-Wei,

The patch series looks good to me. Given the extra conditions should
there be some updates to:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/test_min_heap.c
to ensure coverage?

Thanks,
Ian

>
> include/linux/min_heap.h | 44 +++++++++++++++++++++-------------------
> 1 file changed, 23 insertions(+), 21 deletions(-)
>
> --
> 2.25.1
>