Re: [PATCH v1] perf env: Avoid recursively taking env->bpf_progs.lock

From: Song Liu
Date: Wed Jan 03 2024 - 12:41:47 EST


On Wed, Jan 3, 2024 at 8:27 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> Em Tue, Jan 02, 2024 at 07:00:53PM -0800, Ian Rogers escreveu:
> > On Wed, Dec 6, 2023 at 5:46 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> > >
> > > Add variants of perf_env__insert_bpf_prog_info, perf_env__insert_btf
> > > and perf_env__find_btf prefixed with __ to indicate the
> > > env->bpf_progs.lock is assumed held. Call these variants when the lock
> > > is held to avoid recursively taking it and potentially having a thread
> > > deadlock with itself.
> > >
> > > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> >
> > Ping.
>
> Applied, with that minor patch reduction hunk and this:
>
> Fixes: f8dfeae009effc0b ("perf bpf: Show more BPF program info in print_bpf_prog_info()")
>
> Song, can I have your Acked-by?

LGTM. Thanks for the fix!

Acked-by: Song Liu <song@xxxxxxxxxx>