Re: [PATCH v3 2/3] soc: mediatek: mtk-socinfo: Add driver for getting chip information

[AngeloGioacchino Del Regno]

Il 20/12/23 12:34, Krzysztof Kozlowski ha scritto:
> On 20/12/2023 11:39, William-tw Lin wrote:
> > Add driver for socinfo retrieval. This patch includes the following:
> > 1. mtk-socinfo driver for chip info retrieval
> > 2. Related changes to Makefile and Kconfig
> >
> > Signed-off-by: William-tw Lin <william-tw.lin@xxxxxxxxxxxx>
>
> ...
>
> > +static struct platform_driver mtk_socinfo = {
> > +	.probe = mtk_socinfo_probe,
> > +	.remove_new = mtk_socinfo_remove,
> > +	.driver = {
> > +		.name = "mtk-socinfo",
> > +	},
> > +};
> > +builtin_platform_driver(mtk_socinfo);
>
> module platform driver, because this is tristate and because this should
> be a module.

Oh! Yes, right! Thanks for catching that, it totally slipped off my brain.

Cheers,
Angelo