Re: linux-next: build failure after merge of the thermal tree

From: Fabio Estevam
Date: Mon Dec 18 2023 - 21:11:04 EST


Hi Stephen,

On 18/12/2023 20:34, Stephen Rothwell wrote:
Hi all,

After merging the thermal tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "__hw_protection_shutdown"
[drivers/platform/chrome/cros_ec_lpcs.ko] undefined!

Caused by commit

726edaad90f6 ("thermal/core: Prepare for introduction of thermal reboot")

Thanks for reporting.

Daniel,

Could you please squash the following fix to the commit above?

diff --git a/kernel/reboot.c b/kernel/reboot.c
index 07eb6537ed8b..f814568525f1 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason, int ms_until_forced, bool shut
if (shutdown)
orderly_poweroff(true);
}
+EXPORT_SYMBOL_GPL(__hw_protection_shutdown);

static int __init reboot_setup(char *str)
{

x86_64 allmodconfig builds successfully with this change.


Thanks,

Fabio Estevam