Re: [RFC PATCH 8/8] firewire: core: change modalias of unit device with backward incompatibility

From: Takashi Sakamoto
Date: Mon Dec 18 2023 - 08:00:30 EST


Hi,

On Mon, Dec 18, 2023 at 02:11:42AM -0800, Adam Goldman wrote:
> Hi,
>
> On Sun, Dec 17, 2023 at 07:30:12PM +0900, Takashi Sakamoto wrote:
> > + vendor_directory = search_directory(root_directory, CSR_DIRECTORY | CSR_VENDOR);
>
> Setting the CSR_DIRECTORY bit here is extraneous since search_directory() also sets it.

Indeed. It is redundant.


Thanks

Takashi Sakamoto