Re: [PATCH 1/6] dt-bindings: mfd: brcm,bcm59056: Convert to YAML

From: Krzysztof Kozlowski
Date: Tue Oct 31 2023 - 09:54:31 EST


On 31/10/2023 10:36, Artur Weber wrote:
>
>
> On 31.10.2023 06:52, Krzysztof Kozlowski wrote:
>> On 30/10/2023 20:36, Artur Weber wrote:
>>> Convert devicetree bindings for the Broadcom BCM59056 PMU MFD from
>>> TXT to YAML format. This patch does not change any functionality;
>>> the bindings remain the same.
>>> ...
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>
>> There is no other feature here, so this should go to regulators directory.
>
> There are no other features *yet*, but the driver will eventually be
> expanded to support the other features of the PMIC (charger, fuel gauge,
> rtc, etc.).

The bindings should be complete regardless of driver support, but if
things are missing then it's okay. It can be in MFD.

>
> In that case, should I move the bindings to regulators for now, and move
> them back when the other features are added, or would it be fine to keep
> it in mfd?
Best regards,
Krzysztof