Re: [PATCH v2] kpageflags: respect folio head-page flag placement

From: Matthew Wilcox
Date: Mon Oct 30 2023 - 19:22:35 EST


On Mon, Oct 30, 2023 at 02:00:05PM -0400, Gregory Price wrote:
> kpageflags reads page-flags directly from the page, even when the
> respective flag is only updated on the headpage of a folio.
>
> Update bitchecks to use PAGEFLAG() interfaces to check folio for the
> referenced, dirty, lru, active, and unevictable bits.

But uptodate, writeback and reclaim (amongst others) are also defined
only on the head page.

> u |= kpf_copy_bit(k, KPF_UPTODATE, PG_uptodate);
> u |= kpf_copy_bit(k, KPF_WRITEBACK, PG_writeback);
>
> u |= kpf_copy_bit(k, KPF_RECLAIM, PG_reclaim);
>
> if (PageSwapCache(page))
> u |= 1 << KPF_SWAPCACHE;
> u |= kpf_copy_bit(k, KPF_SWAPBACKED, PG_swapbacked);
>
> u |= kpf_copy_bit(k, KPF_MLOCKED, PG_mlocked);