Re: [PATCH] [RFC] Add missing NULL check in `tls_strp_check_queue_ok`

From: Jakub Kicinski
Date: Mon Oct 30 2023 - 18:05:18 EST


On Mon, 30 Oct 2023 14:57:29 -0700 Frederik Deweerdt wrote:
> We see `tls_strp_check_queue_ok` running into a NULL deref when
> evaluating `TCP_SKB_CB(skb)->seq`.
>
> This commit attempts to address the issue by exiting the loop if
> skb->next is NULL, and has proven stable under load.
>
> That said i don't understand the code enough to convince myself that
> the NULL check is indeed required, and i would be happy gather data if
> that's useful.

Hm. Can you share the decoded stack trace?