Re: [PATCH v12] exec: Fix dead-lock in de_thread with ptrace_attach

From: kernel test robot
Date: Mon Oct 30 2023 - 05:01:05 EST


Hi Bernd,

kernel test robot noticed the following build warnings:

[auto build test WARNING on kees/for-next/execve]
[also build test WARNING on kees/for-next/seccomp shuah-kselftest/next shuah-kselftest/fixes linus/master v6.6]
[cannot apply to next-20231030]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Bernd-Edlinger/exec-Fix-dead-lock-in-de_thread-with-ptrace_attach/20231030-133021
base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve
patch link: https://lore.kernel.org/r/AS8P193MB1285DF698D7524EDE22ABFA1E4A1A%40AS8P193MB1285.EURP193.PROD.OUTLOOK.COM
patch subject: [PATCH v12] exec: Fix dead-lock in de_thread with ptrace_attach
config: loongarch-randconfig-002-20231030 (https://download.01.org/0day-ci/archive/20231030/202310301604.K866zRJ8-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231030/202310301604.K866zRJ8-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310301604.K866zRJ8-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> kernel/cred.c:443: warning: duplicate section name 'Return'


vim +/Return +443 kernel/cred.c

435
436 /**
437 * is_dumpability_changed - Will changing creds from old to new
438 * affect the dumpability in commit_creds?
439 *
440 * Return: false - dumpability will not be changed in commit_creds.
441 * Return: true - dumpability will be changed to non-dumpable.
442 *
> 443 * @old: The old credentials
444 * @new: The new credentials
445 */
446 bool is_dumpability_changed(const struct cred *old, const struct cred *new)
447 {
448 if (!uid_eq(old->euid, new->euid) ||
449 !gid_eq(old->egid, new->egid) ||
450 !uid_eq(old->fsuid, new->fsuid) ||
451 !gid_eq(old->fsgid, new->fsgid) ||
452 !cred_cap_issubset(old, new))
453 return true;
454
455 return false;
456 }
457

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki