Re: [PATCH v3] dt-bindings: hwmon: lm87: convert to YAML

From: Krzysztof Kozlowski
Date: Sat Oct 28 2023 - 11:04:24 EST


On 28/10/2023 13:59, peiyu li wrote:
>>
>> On 28/10/2023 10:20, Li peiyu wrote:
>>> Convert the lm87 hwmon sensor bindings to DT schema
>>>
>>> Signed-off-by: Li peiyu <579lpy@xxxxxxxxx>
>>> ---
>>> Changes for v3:
>>> - add type definition of has-temp3, has-in6, has-in7
>>> - Change the description of has-temp3
>>> Changes for v2:
>>> - replace node name lm87 with sensor
>>> - replace character '\t' with spaces
>>>
>>> .../devicetree/bindings/hwmon/lm87.txt | 30 ---------
>>> .../devicetree/bindings/hwmon/lm87.yaml | 62 +++++++++++++++++++
>>
>> Nothing improved.
>>
>> Stop ignoring feedback. You must respond to it or implement it.
>>
>> Best regards,
>> Krzysztof
>>
> I'm so sorry for that.For v3 I just run make dt_binding_check and forget to

You even removed my address when replying this!

> run checkpatch.pl,resulting in not finding an extra space.Now running the
> dt_binding_check on my computer will cause an error regarding the
> ti,ds90ub960.yaml
> file when I specify the file to be checked as lm87.yaml. This error will occur
> even if I specify other files, I am not sure if it will have an
> impact.I'll submit
> v4.If there are still issues,please tell me the reason again.Sorry again.


v4 did not improve. Please explain me carefully how did you implement
these two feedbacks from first version, so 25th of Oct:

> Please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC.

> Also, please use filename like compatible.

Best regards,
Krzysztof