Re: [PATCH 3/7] drm/msm/gem: Don't queue job to sched in error cases

From: Dmitry Baryshkov
Date: Fri Oct 27 2023 - 21:16:28 EST


On Fri, 27 Oct 2023 at 19:59, Rob Clark <robdclark@xxxxxxxxx> wrote:
>
> From: Rob Clark <robdclark@xxxxxxxxxxxx>
>
> We shouldn't be running the job in error cases. This also avoids having
> to think too hard about where the objs get unpinned (and if necessary,
> the resv takes over tracking that the obj is busy).. ie. error cases it
> always happens synchronously, and normal cases it happens from scheduler
> job_run() callback.
>
> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> ---
> drivers/gpu/drm/msm/msm_gem_submit.c | 3 +++
> 1 file changed, 3 insertions(+)

--
With best wishes
Dmitry