Re: [PATCH v4 3/4] pwm: bcm2835: allow pwm driver to be used in atomic context

[Uwe Kleine-König]

Hello Sean,

On Fri, Oct 27, 2023 at 10:20:46AM +0100, Sean Young wrote:
> +	pc->rate = clk_get_rate(pc->clk);
> +	if (!pc->rate) {
> +		dev_err(pc->dev, "failed to get clock rate\n");
> +		ret = -EINVAL;

Other error paths in this driver use dev_err_probe(). The most compact
way here would be:

	ret = dev_err_probe(pc->dev, -EINVAL, "....");

but maybe

	ret = -EINVAL;
	dev_err_probe(pc->dev, ret, "...");

is a bit easier to parse for a human?!

Otherwise looks reasonable.

Thanks,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature