Re: [PATCH v2] Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT"

From: André Draszik
Date: Fri Oct 27 2023 - 09:14:21 EST


On Fri, 2023-10-27 at 15:03 +0200, Miklos Szeredi wrote:

> Again, upstream and downstream.  There's a reason why some companies
> have upstream first policies: because it's less painful in the long
> run.  Android having decided to go ahead and add that patch is not my
> problem, and I really really don't want to care.
>
> Having said all that, if there's a regression that someone reports
> for
> upstream flags (even on a vendor kernel), I'll just revert the patch
> right away.

The patch in question has broken all users that use the higher flags
and that don't use your version of libfuse, not just Android. You're
filtering them out now when you didn't at the time that those
('official) high flags were added. There are a couple more high flags
than just the one that Android added.


Cheers,
Andre'