Re: [PATCH 1/2] tty: serial: 8250: Fix MOXA RS422/RS485 PCIe boards not work by default
From: kernel test robot
Date: Fri Oct 27 2023 - 05:10:28 EST
Hi Crescent,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next next-20231026]
[cannot apply to tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.6-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Crescent-CY-Hsieh/tty-serial-8250-Fix-MOXA-RS422-RS485-PCIe-boards-not-work-by-default/20231027-142745
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20231027062440.7749-2-crescentcy.hsieh%40moxa.com
patch subject: [PATCH 1/2] tty: serial: 8250: Fix MOXA RS422/RS485 PCIe boards not work by default
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231027/202310271618.QBCWA4yo-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310271618.QBCWA4yo-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310271618.QBCWA4yo-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/tty/serial/8250/8250_pci.c:2001:5: warning: no previous prototype for 'pci_moxa_supported_rs' [-Wmissing-prototypes]
2001 | u32 pci_moxa_supported_rs(struct pci_dev *dev)
| ^~~~~~~~~~~~~~~~~~~~~
vim +/pci_moxa_supported_rs +2001 drivers/tty/serial/8250/8250_pci.c
2000
> 2001 u32 pci_moxa_supported_rs(struct pci_dev *dev)
2002 {
2003 switch (dev->device & 0x0F00) {
2004 case 0x0000:
2005 case 0x0600:
2006 return MOXA_SUPP_RS232;
2007 case 0x0100:
2008 return MOXA_SUPP_RS232 | MOXA_SUPP_RS422 | MOXA_SUPP_RS485;
2009 case 0x0300:
2010 return MOXA_SUPP_RS422 | MOXA_SUPP_RS485;
2011 }
2012 return 0;
2013 }
2014
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki