Re: [PATCH 00/10] staging: rtl8192e: Convert array rx_ring[] to rx_ring

From: Dan Carpenter
Date: Thu Oct 26 2023 - 03:10:07 EST


On Thu, Oct 26, 2023 at 07:43:26AM +0200, Philipp Hortmann wrote:
> Remove some functions that always return false or zero.
> Remove a loop that is always executed one time and convert arrays to variables.
> Remove some unused constants.
>
> Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s)
> Transferred this patch over wlan connection of rtl8192e.
>
> Philipp Hortmann (10):
> staging: rtl8192e: Remove HTIOTActIsDisableMCS14()
> staging: rtl8192e: Remove HTIOTActIsDisableMCS15()
> staging: rtl8192e: Remove HTIOTActIsDisableMCSTwoSpatialStream()
> staging: rtl8192e: Remove HTIOTActIsDisableEDCATurbo()
> staging: rtl8192e: Remove loops with constant MAX_RX_QUEUE
> staging: rtl8192e: Convert array rx_ring[] to variable rx_ring
> staging: rtl8192e: Convert array rx_buf[][] to array rx_buf[]
> staging: rtl8192e: Convert array rx_ring_dma[] to variable rx_ring_dma
> staging: rtl8192e: Convert array rx_idx[] to variable rx_idx
> staging: rtl8192e: Remove unused constants starting with MAX_RX_QUEUE
>

Looks good to me.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter