Re: [PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO

[Sui Jingfeng]

Hi,


On 2023/10/25 18:11, Paul Kocialkowski wrote:
> Hi,
>
> On Tue 20 Jun 23, 11:56, Sui Jingfeng wrote:
> > Hi,
> >
> > On 2023/6/8 15:15, Paul Kocialkowski wrote:
> > > Hi,
> > >
> > > On Thu 08 Jun 23, 10:42, Sui Jingfeng wrote:
> > > > drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this
> > > > two kconfig option, otherwise the driver failed to compile on platform
> > > > without REGMAP_MMIO selected:
> > > >
> > > > ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined!
> > > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> > > > make: *** [Makefile:1978: modpost] Error 2
> > > >
> > > > Signed-off-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> > > Thanks for the fix, looks good to me!
> > >
> > > Acked-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>
> > Thanks a lot,
> >
> > Please don't forget to push this to drm-misc or drm-tip if you has the time,
> > as (even though trivial) it's precious for me.
> So I totally forgot about this and only pushed it to drm-misc-fixes now.
> Sincere apologies for this.
>
> Thanks again for spotting this issue and submitting the fix.
>
> Paul


Nice, thanks your reply.


> > > Cheers,
> > >
> > > Paul
> > >
> > > > ---
> > > >    drivers/gpu/drm/logicvc/Kconfig | 2 ++
> > > >    1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/logicvc/Kconfig b/drivers/gpu/drm/logicvc/Kconfig
> > > > index fa7a88368809..1df22a852a23 100644
> > > > --- a/drivers/gpu/drm/logicvc/Kconfig
> > > > +++ b/drivers/gpu/drm/logicvc/Kconfig
> > > > @@ -5,5 +5,7 @@ config DRM_LOGICVC
> > > >    	select DRM_KMS_HELPER
> > > >    	select DRM_KMS_DMA_HELPER
> > > >    	select DRM_GEM_DMA_HELPER
> > > > +	select REGMAP
> > > > +	select REGMAP_MMIO
> > > >    	help
> > > >    	  DRM display driver for the logiCVC programmable logic block from Xylon
> > > > --
> > > > 2.25.1
> > --
> > Jingfeng