Re: [PATCH] net: sunrpc: Fix an off by one in root_nfs_cat()

From: Benjamin Coddington
Date: Wed Oct 25 2023 - 08:35:57 EST


On 24 Oct 2023, at 17:55, Christophe JAILLET wrote:

> The intent is to check if the strings' are truncated or not. So, >= should
> be used instead of >, because strlcat() and snprintf() return the length of
> the output, excluding the trailing NULL.
>
> Fixes: a02d69261134 ("SUNRPC: Provide functions for managing universal addresses")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Benjamin Coddington <bcodding@xxxxxxxxxx>

Ben