Re: [PATCH v9 01/20] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties

From: Krzysztof Kozlowski
Date: Wed Oct 25 2023 - 06:42:42 EST


On 25/10/2023 12:28, Conor Dooley wrote:
> Hi John,
>
> On Mon, Oct 23, 2023 at 11:09:50PM -0400, John Clark wrote:
>>> On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
>>>> On 20/10/2023 12:43, Minda Chen wrote:
>>>>> Add PLDA XpressRICH PCIe host common properties dt-binding doc.
>>>>> Microchip PolarFire PCIe host using PLDA IP.
>>>>> Move common properties from Microchip PolarFire PCIe host
>>>>> to PLDA files.
>>>>>
>>>>> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
>>>>> Reviewed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>
>>>>> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>>>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>>>>> ---
>>>>> .../bindings/pci/microchip,pcie-host.yaml | 55 +-------------
>>>>> .../pci/plda,xpressrich3-axi-common.yaml | 75 +++++++++++++++++++
>>>> Where was this patch reviewed?
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>> This Conor's review tag. v2 : https://patchwork.kernel.org/project/linux-pci/patch/20230727103949.26149-2-minda.chen@xxxxxxxxxxxxxxxx/
>>> This is Rob's review tag v3: https://patchwork.kernel.org/project/linux-pci/patch/20230814082016.104181-2-minda.chen@xxxxxxxxxxxxxxxx/
>>
>> Tested-by: John Clark <inindev@xxxxxxxxx>:
>> https://github.com/inindev/visionfive2/tree/main/kernel/patches
>
> I suspect you don't mean that you tested this individual dt-binding, but
> rather that you tested the whole series. If so, you should probably
> provide this tested-by against the cover-letter instead of this bindings
> patch.

Yeah, otherwise I would like to hear how do you test bindings (other
than dt_binding_check which is something similar to testing as compiling
code).

Best regards,
Krzysztof