Re: [PATCH] s390/sclp: replace deprecated strncpy with strtomem

From: Kees Cook
Date: Tue Oct 24 2023 - 19:57:32 EST


On Tue, Oct 24, 2023 at 04:46:04PM -0700, Kees Cook wrote:
> > Instead use strtomem() as `e.id` is already marked as nonstring:
> > | char id[4] __nonstring;
>
> I'm surprised the compiler didn't complain about this -- I thought that
> was the point of the __nonstring attribute: to diagnose when used with a
> string function. Hmpf.

Wow. GCC only warns if you call strlen() on it, but literally nothing
else... :(

--
Kees Cook