Re: [PATCH net-next 1/2] i40e: Do not call devlink_port_type_clear()

[Jiri Pirko]

Tue, Oct 24, 2023 at 02:51:08PM CEST, ivecera@xxxxxxxxxx wrote:
>Do not call devlink_port_type_clear() prior devlink port unregister
>and let devlink core to take care about it.
>
>Reproducer:
>[root@host ~]# rmmod i40e
>[ 4539.964699] i40e 0000:02:00.0: devlink port type for port 0 cleared without a software interface reference, device type not supported by the kernel?
>[ 4540.319811] i40e 0000:02:00.1: devlink port type for port 1 cleared without a software interface reference, device type not supported by the kernel?
>
>Fixes: 9e479d64dc58 ("i40e: Add initial devlink support")
>Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>

Ivan, I see that even if we have checks and warnings, it is not enough :)

Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>

Btw, some (even brief) cover letter for patchset would be nice.