fs/ubifs/replay.c:71: warning: Function parameter or member 'hash' not described in 'replay_entry'

From: kernel test robot
Date: Tue Oct 24 2023 - 08:15:59 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d88520ad73b79e71e3ddf08de335b8520ae41c5c
commit: 16a26b20d2afd0cf063816725b45b12e78d5bb31 ubifs: authentication: Add hashes to index nodes
date: 5 years ago
config: x86_64-randconfig-x012-20230629 (https://download.01.org/0day-ci/archive/20231024/202310241921.eZLWvBcv-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231024/202310241921.eZLWvBcv-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310241921.eZLWvBcv-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> fs/ubifs/replay.c:71: warning: Function parameter or member 'hash' not described in 'replay_entry'
>> fs/ubifs/replay.c:359: warning: Function parameter or member 'hash' not described in 'insert_node'
>> fs/ubifs/replay.c:408: warning: Function parameter or member 'hash' not described in 'insert_dent'
fs/ubifs/replay.c:792: warning: Excess function parameter 'ref_lnum' description in 'validate_ref'
fs/ubifs/replay.c:792: warning: Excess function parameter 'ref_offs' description in 'validate_ref'
fs/ubifs/replay.o: warning: objtool: ubifs_validate_entry()+0x225: sibling call from callable instruction with modified stack frame
fs/ubifs/replay.o: warning: objtool: replay_bud()+0x4e0: sibling call from callable instruction with modified stack frame


vim +71 fs/ubifs/replay.c

1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 37
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 38 /**
debf12d54182b3 Artem Bityutskiy 2011-05-15 39 * struct replay_entry - replay list entry.
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 40 * @lnum: logical eraseblock number of the node
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 41 * @offs: node offset
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 42 * @len: node length
074bcb9b5ce698 Artem Bityutskiy 2011-05-15 43 * @deletion: non-zero if this entry corresponds to a node deletion
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 44 * @sqnum: node sequence number
debf12d54182b3 Artem Bityutskiy 2011-05-15 45 * @list: links the replay list
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 46 * @key: node key
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 47 * @nm: directory entry name
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 48 * @old_size: truncation old size
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 49 * @new_size: truncation new size
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 50 *
debf12d54182b3 Artem Bityutskiy 2011-05-15 51 * The replay process first scans all buds and builds the replay list, then
debf12d54182b3 Artem Bityutskiy 2011-05-15 52 * sorts the replay list in nodes sequence number order, and then inserts all
debf12d54182b3 Artem Bityutskiy 2011-05-15 53 * the replay entries to the TNC.
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 54 */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 55 struct replay_entry {
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 56 int lnum;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 57 int offs;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 58 int len;
16a26b20d2afd0 Sascha Hauer 2018-09-07 59 u8 hash[UBIFS_HASH_ARR_SZ];
074bcb9b5ce698 Artem Bityutskiy 2011-05-15 60 unsigned int deletion:1;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 61 unsigned long long sqnum;
debf12d54182b3 Artem Bityutskiy 2011-05-15 62 struct list_head list;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 63 union ubifs_key key;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 64 union {
f4f61d2cc6d878 Richard Weinberger 2016-11-11 65 struct fscrypt_name nm;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 66 struct {
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 67 loff_t old_size;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 68 loff_t new_size;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 69 };
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 70 };
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 @71 };
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 72

:::::: The code at line 71 was first introduced by commit
:::::: 1e51764a3c2ac05a23a22b2a95ddee4d9bffb16d UBIFS: add new flash file system

:::::: TO: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
:::::: CC: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki