Re: [PATCH net-next 1/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet switch

From: Romain Gantois
Date: Tue Oct 24 2023 - 08:13:15 EST


On Tue, 24 Oct 2023, Krzysztof Kozlowski wrote:

> Rob's bot might be using not-yet-released dtschema from main branch,
> thus the error. However the error is true: you added a custom field
> without type. That's why I asked: where is it defined?
>

I didn't define it anywhere, that's an oversight on my part. The psgmii_ethphy
property is a handle to an MDIO device, which I thought was integrated to the
PSGMII bus in the IPQ4019. However, I just learned from Robert Marko that this
MDIO device corresponds to a SoC-facing PHY integrated in the external QCA807x
IP. Therefore, I'm not convinced that this MDIO device should be handled by
the ESS driver.

I'm going to have to consider refactoring the psgmii_ethphy handling out of
the IPQESS driver, which would make this device tree property unnecessary.

Best Regards,

Romain