Re: [PATCH v4 net-next 1/3] ipv6: drop feature RTAX_FEATURE_ALLFRAG

From: Eric Dumazet
Date: Tue Oct 24 2023 - 06:31:08 EST


On Tue, Oct 24, 2023 at 12:22 PM Florian Westphal <fw@xxxxxxxxx> wrote:
>
> Yan Zhai <yan@xxxxxxxxxxxxxx> wrote:
> > #define IPCORK_OPT 1 /* ip-options has been held in ipcork.opt */
> > -#define IPCORK_ALLFRAG 2 /* always fragment (for ipv6 for now) */
> > +#define IPCORK_ALLFRAG 2 /* (unused) always fragment (for ipv6 for now) */
>
> Nit: Why not remove the ALLFRAG define as well?

I agree, this is not exposed to user space and should be deleted.

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>

>
> Otherwise the series looks good to me, thanks!
>
> Reviewed-by: Florian Westphal <fw@xxxxxxxxx>
>