Re: [PATCH 07/10] scsi: libsas: Delete sas_ssp_task.task_prio

[Hannes Reinecke]

On 10/24/23 12:07, John Garry wrote:
> On 09/10/2023 07:55, Hannes Reinecke wrote:
> > > diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> > > index d77db53cbd8d..5b2e6932c564 100644
> > > --- a/include/scsi/libsas.h
> > > +++ b/include/scsi/libsas.h
> > > @@ -565,7 +565,6 @@ enum task_attribute {
> > >   struct sas_ssp_task {
> > >       u8     LUN[8];
> > >       enum   task_attribute task_attr;
> > > -    u8     task_prio;
> > >       struct scsi_cmnd *cmd;
> > >   };
> > Hmm. While true in general, we lose information on how the 'prio' 
> > field is coded for the various drivers.
> > Would it be an idea to use explicitly state TASK_ATTR_SIMPLE
> > in the various drivers such that we know what to fix if we ever
> > decide to bring task attributes back to life?
>
> The HW encoding for these drivers is the same as in the SAS COMMAND 
> frame - Command information unit structure, right? So the amount of info 
> lost is reduced. And we also have source control history.
>
> I'd be more inclined to get rid of setting task attributes similarly as 
> well.
Fair enough.

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes