Hello, Markuss,Yeah, I have not received your first series, only knew of it when the replies came. It's fine though :)
thank you for your response and please forgive that my original emails
didn't reach you - I am trying to see if I can get the SMTP server I use
for my primary address officially authorized to send emails in its name
so that Google does not reject them.
To be fair, this driver should work with all Imagis3 chips, which couldI will be sure to drop the renaming for v2.
be a better name for it. However, I agree with Jeff here: the driver
doesn't necessarily need renaming.
Additionally, there used to be my series [1] that generalized theI have come across your patch series and in fact my original experiments
driver, but it never got applied. I will re-send it. It introduces
`struct imagis_properties`, which contains register addresses for the
registers that we use to read the touch input. In your specific case, I
believe it should be:
static const struct imagis_properties imagis_3032c_data =
{
.interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
.touch_coord_cmd = IST3038C_REG_TOUCH_COORD,
.whoami_cmd = IST3038C_REG_CHIPID,
.whoami_val = IST3032C_WHOAMI, /* change it to your whoami */
};
were based on it. However I thought it was abandoned and decided not to
try to make any further generalizations to the driver for now, except
making it work with IST3032C. Should I then perhaps wait before your
series gets applied before sending v2 of my changes? Or should I send
you a patch on top of your series, where I would add the `struct
imagis_properties` for the IST3032C (which you surely could do yourself,
but I can at least test it with my device). Please let me know if and
how we should coordinate.
As for the voltage set, I believe this does not belong in a kernelPlease see my response to Jeff regarding this. I will be happy to hear
driver. You should set it in device-tree with `regulator-max-microvolt`
and `regulator-min-microvolt`.
your thoughts on what I propose.
- Markuss
Kind regards,
K. B.